Skip to content

hfpp2012 / react-spd

Go to a project
Commit f4ee87ae by hfpp2012 yinsigan
Options

eslint

1 parent 629317ec
Expand all
Inline Side-by-side
Showing 10 changed files with 229 additions and 14 deletions
.eslintrc.js 0 → 100644
// @remove-on-eject-begin
/**
* Copyright (c) 2015-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*/
// @remove-on-eject-end
// Inspired by https://github.com/airbnb/javascript but less opinionated.
// We use eslint-loader so even warnings are very visibile.
// This is why we only use "WARNING" level for potential errors,
// and we don't use "ERROR" level at all.
// In the future, we might create a separate list of rules for production.
// It would probably be more strict.
module.exports = {
root: true,
parser: 'babel-eslint',
// import plugin is temporarily disabled, scroll below to see why
plugins: [/*'import', */'flowtype', 'jsx-a11y', 'react'],
env: {
browser: true,
commonjs: true,
es6: true,
jest: true,
node: true
},
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
ecmaFeatures: {
jsx: true,
generators: true,
experimentalObjectRestSpread: true
}
},
settings: {
'import/ignore': [
'node_modules',
'\\.(json|css|jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$',
],
'import/extensions': ['.js'],
'import/resolver': {
node: {
extensions: ['.js', '.json']
}
}
},
rules: {
// http://eslint.org/docs/rules/
'array-callback-return': 'warn',
'default-case': ['warn', { commentPattern: '^no default$' }],
'dot-location': ['warn', 'property'],
eqeqeq: ['warn', 'allow-null'],
'guard-for-in': 'warn',
'new-parens': 'warn',
'no-array-constructor': 'warn',
'no-caller': 'warn',
'no-cond-assign': ['warn', 'always'],
'no-const-assign': 'warn',
'no-control-regex': 'warn',
'no-delete-var': 'warn',
'no-dupe-args': 'warn',
'no-dupe-class-members': 'warn',
'no-dupe-keys': 'warn',
'no-duplicate-case': 'warn',
'no-empty-character-class': 'warn',
'no-empty-pattern': 'warn',
'no-eval': 'warn',
'no-ex-assign': 'warn',
'no-extend-native': 'warn',
'no-extra-bind': 'warn',
'no-extra-label': 'warn',
'no-fallthrough': 'warn',
'no-func-assign': 'warn',
'no-implied-eval': 'warn',
'no-invalid-regexp': 'warn',
'no-iterator': 'warn',
'no-label-var': 'warn',
'no-labels': ['warn', { allowLoop: false, allowSwitch: false }],
'no-lone-blocks': 'warn',
'no-loop-func': 'warn',
'no-mixed-operators': ['warn', {
groups: [
['&', '|', '^', '~', '<<', '>>', '>>>'],
['==', '!=', '===', '!==', '>', '>=', '<', '<='],
['&&', '||'],
['in', 'instanceof']
],
allowSamePrecedence: false
}],
'no-multi-str': 'warn',
'no-native-reassign': 'warn',
'no-negated-in-lhs': 'warn',
'no-new-func': 'warn',
'no-new-object': 'warn',
'no-new-symbol': 'warn',
'no-new-wrappers': 'warn',
'no-obj-calls': 'warn',
'no-octal': 'warn',
'no-octal-escape': 'warn',
'no-redeclare': 'warn',
'no-regex-spaces': 'warn',
'no-restricted-syntax': [
'warn',
'LabeledStatement',
'WithStatement',
],
'no-script-url': 'warn',
'no-self-assign': 'warn',
'no-self-compare': 'warn',
'no-sequences': 'warn',
'no-shadow-restricted-names': 'warn',
'no-sparse-arrays': 'warn',
'no-template-curly-in-string': 'warn',
'no-this-before-super': 'warn',
'no-throw-literal': 'warn',
'no-undef': 'error',
'no-unexpected-multiline': 'warn',
'no-unreachable': 'warn',
'no-unused-expressions': 'warn',
'no-unused-labels': 'warn',
'no-unused-vars': ['warn', {
vars: 'local',
varsIgnorePattern: '^_',
args: 'none'
}],
'no-use-before-define': ['warn', 'nofunc'],
'no-useless-computed-key': 'warn',
'no-useless-concat': 'warn',
'no-useless-constructor': 'warn',
'no-useless-escape': 'warn',
'no-useless-rename': ['warn', {
ignoreDestructuring: false,
ignoreImport: false,
ignoreExport: false,
}],
'no-with': 'warn',
'no-whitespace-before-property': 'warn',
'operator-assignment': ['warn', 'always'],
radix: 'warn',
'require-yield': 'warn',
'rest-spread-spacing': ['warn', 'never'],
strict: ['warn', 'never'],
'unicode-bom': ['warn', 'never'],
'use-isnan': 'warn',
'valid-typeof': 'warn',
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/
// TODO: import rules are temporarily disabled because they don't play well
// with how eslint-loader only checks the file you change. So if module A
// imports module B, and B is missing a default export, the linter will
// record this as an issue in module A. Now if you fix module B, the linter
// will not be aware that it needs to re-lint A as well, so the error
// will stay until the next restart, which is really confusing.
// This is probably fixable with a patch to eslint-loader.
// When file A is saved, we want to invalidate all files that import it
// *and* that currently have lint errors. This should fix the problem.
// 'import/default': 'warn',
// 'import/export': 'warn',
// 'import/named': 'warn',
// 'import/namespace': 'warn',
// 'import/no-amd': 'warn',
// 'import/no-duplicates': 'warn',
// 'import/no-extraneous-dependencies': 'warn',
// 'import/no-named-as-default': 'warn',
// 'import/no-named-as-default-member': 'warn',
// 'import/no-unresolved': ['warn', { commonjs: true }],
// https://github.com/yannickcr/eslint-plugin-react/tree/master/docs/rules
'react/jsx-equals-spacing': ['warn', 'never'],
'react/jsx-no-duplicate-props': ['warn', { ignoreCase: true }],
'react/jsx-no-undef': 'warn',
'react/jsx-pascal-case': ['warn', {
allowAllCaps: true,
ignore: [],
}],
'react/jsx-uses-react': 'warn',
'react/jsx-uses-vars': 'warn',
'react/no-deprecated': 'warn',
'react/no-direct-mutation-state': 'warn',
'react/no-is-mounted': 'warn',
'react/react-in-jsx-scope': 'warn',
'react/require-render-return': 'warn',
// https://github.com/evcohen/eslint-plugin-jsx-a11y/tree/master/docs/rules
'jsx-a11y/aria-role': 'warn',
'jsx-a11y/img-has-alt': 'warn',
'jsx-a11y/img-redundant-alt': 'warn',
'jsx-a11y/no-access-key': 'warn',
// https://github.com/gajus/eslint-plugin-flowtype
'flowtype/define-flow-type': 'warn',
'flowtype/require-valid-file-annotation': 'warn',
'flowtype/use-flow-type': 'warn'
}
};
package.json
......@@ -24,11 +24,17 @@
},
"devDependencies": {
"babel-core": "^6.24.1",
"babel-eslint": "^7.2.3",
"babel-loader": "^7.0.0",
"babel-plugin-transform-decorators-legacy": "^1.3.4",
"babel-preset-es2015": "^6.24.1",
"babel-preset-react": "^6.24.1",
"css-loader": "^0.28.1",
"eslint": "^3.19.0",
"eslint-loader": "^1.7.1",
"eslint-plugin-flowtype": "^2.33.0",
"eslint-plugin-jsx-a11y": "^4.0.0",
"eslint-plugin-react": "^7.0.1",
"extract-text-webpack-plugin": "^2.1.0",
"node-sass": "^4.5.3",
"open-browser-webpack-plugin": "^0.0.5",
......
src/components/Element.js
......@@ -216,8 +216,8 @@ export default class Element extends React.Component {
id: this.props.id,
name: this.state.name
}
if (this.state.name != this.state.prev_name) {
if (this.state.name.trim() == "") {
if (this.state.name !== this.state.prev_name) {
if (this.state.name.trim() === "") {
this.setState({ name: this.state.prev_name })
} else {
EventEmitter.dispatch('element:update', element)
......@@ -229,7 +229,7 @@ export default class Element extends React.Component {
handleDoubleClick() {
const childrenObjectType = this.props.childrenObjectType
const url = `/web/regional_design/${this.props.id}?object=${childrenObjectType}`
if (childrenObjectType != 'drug_brandreth_grid') {
if (childrenObjectType !== 'drug_brandreth_grid') {
this.props.hashHistory.push(url)
}
}
......
src/components/ModalRepoForm.js
import React from 'react'
import { Modal, Button } from 'react-bootstrap'
import { Form, FormGroup, Col, FormControl, ControlLabel } from 'react-bootstrap'
import EventEmitter from '../libs/eventEmitter'
import $ from 'jquery'
import autobind from 'autobind-decorator'
......
src/components/RegionalDesign.js
......@@ -43,7 +43,7 @@ export default class RegionalDesign extends React.Component {
this.getJSON(url)
EventEmitter.subscribe('moveDropZone', function(element){
if (element.target_type == this.state.object_type) {
if (element.target_type === this.state.object_type) {
this.addElement(element)
} else {
EventEmitter.dispatch('alert', '不能移动该元件')
......@@ -86,7 +86,7 @@ export default class RegionalDesign extends React.Component {
dataType: 'JSON',
data: data,
success: function(data) {
}.bind(this)
}
})
}
......
src/index.js
......@@ -3,9 +3,7 @@ import ReactDOM from 'react-dom'
import Spd from './containers/Spd'
import {
HashRouter as Router,
Route,
Link,
IndexRoute
Route
} from 'react-router-dom'
import RegionalDesign from './components/RegionalDesign'
......
src/libs/move.js
......@@ -10,8 +10,8 @@ function startMove(obj, json, endFn) {
let iCur = 0
if (attr == 'opacity') {
if (Math.round(parseFloat(getStyle(obj, attr)) * 100) == 0) {
if (attr === 'opacity') {
if (Math.round(parseFloat(getStyle(obj, attr)) * 100) === 0) {
iCur = Math.round(parseFloat(getStyle(obj, attr)) * 100)
} else {
iCur = Math.round(parseFloat(getStyle(obj, attr)) * 100) || 100
......@@ -23,11 +23,11 @@ function startMove(obj, json, endFn) {
let iSpeed = (json[attr] - iCur)/8
iSpeed = iSpeed >0 ? Math.ceil(iSpeed) : Math.floor(iSpeed)
if (iCur != json[attr]) {
if (iCur !== json[attr]) {
bBtn = false
}
if (attr == 'opacity') {
if (attr === 'opacity') {
obj.style.filter = 'alpha(opacity=' + (iCur + iSpeed) + ')'
obj.style.opacity = (iCur + iSpeed)/100
} else {
......
webpack.config.js
......@@ -43,7 +43,7 @@ module.exports = {
},
module: {
loaders: [
{ test: /\.(js|jsx)$/, loader: 'babel-loader', exclude: /node_modules/ },
{ test: /\.(js|jsx)$/, loader: ['babel-loader', 'eslint-loader'], exclude: /node_modules/ },
{ test: /\.scss/, loader: extractSass, exclude: /node_modules/ }
]
},
......
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!